Hi Thomas, On Fri, 6 Nov 2009 16:56:34 +0100 (CET), Thomas Gleixner wrote: > On Fri, 6 Nov 2009, Jean Delvare wrote: > > I'm not sure why we need to hold the mutex here? My understanding is > > that watchdog_data_mutex protects watchdog_data_list and each > > watchdog's kref. And the above code doesn't touch either. > > > > What I am more worried about is why ident is declared static. This > > looks like a bug to me. Instead of abusing watchdog_data_mutex to > > workaround this, I'd rather remove the "static". I guess that the > > current code happens to work because neither data->revision nor > > nowayout can change over time, but this looks needlessly fragile. > > Right, we can change ident to be non static instead of abusing the > mutex. Stupid me. Will fix. This was quite some time ago and I can't seem to find an updated version of your patch that I could apply. Care to send one? Thanks, -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
