On Wed, Jul 29, 2009 at 10:44:46PM +0100, Ben Dooks wrote: [...] > > + const struct spi_device_id *id_table; > > + int (*probe_id)(struct spi_device *spi, > > + const struct spi_device_id *id); > > how about leaving it at just probe and have either a call or a field > in the device that you can look at to see if this was a new style of > call? There are no technical difficulties with that, but it would be inconsitent wrt other "device table"-aware buses (i2c, pci, of). Note that I'm getting rid of probe_id function in patch 5/7, as a cleanup step. I want to keep "new features" and "api cleanups" separate. That way it's easier to review the changes. Thanks! -- Anton Vorontsov email: cbouatmailru at gmail.com irc://irc.freenode.net/bd2
