Hello Jean, Hans, Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not. Jean, I know you're on vacation, so take your time :) BTW I spend some time with my girlfriend at the Cote d'Azur last year. Probably the best vacation I've ever had. But speaking french is very difficult :) Thanks, Andre --- Documentation/hwmon/tmp421 | 36 ++++ drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile | 1 drivers/hwmon/tmp421.c | 349 +++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 396 insertions(+)