Mark Brown wrote: > On 25 Jun 2009, at 17:11, Jonathan Cameron <jic23 at cam.ac.uk> wrote: > >> >> Signed-off-by: Jonathan Cameron <jic23 at cam.ac.uk> >> >> --- >> Data sheet trawling has established that, of the devices listed by >> this driver, there are two voltage ranges. (2.7-5.5 or 3-5.5) > > You shouldn't need to have the driver request the voltage range it needs > like this - the machine constraints should deal with that. In general > you should only actively manage the voltage in a consumer if you need to > change voltages dynamically. Ok, I'd misunderstood that. > > Doing this would also mean that the driver would be able to use the stub > consumer API that is provided when regulator support is disabled. That makes sense, I'll do a repost with just the enable / disable stuff. Thanks, Jonathan
