Hi Jim, On Wed, Jul 16, 2008 at 1:25 AM, Jean Delvare <khali at linux-fr.org> wrote: >> >> David, >> >> do you have a preference wrt fn-ptr ? and if so, a single fn with 1 arg >> >> : 0,1,2 for enter/exit/query ? >> >> do you have any use for a flag bit ? is there generality in it ? >> >> I think we could just use the same enter and exit sequences for >> everything, and not make it customizable. Does that sound OK? > > No. We can have a universal exit sequence, but enter sequences are > per-chip (or actually per chip family). That's even one part of the > device identification (lets us differentiate between two chips with the > same device ID register value.) I think a fn-ptr would be fine. The function could take as an arg enter/exit/query (0, 1, 2) and a pointer to a byte array with offset, value, offset, value pairs. So I see the function having 3 args: void (* fn-ptr)(int which, char * sequence, int sequence_max_length); David
