Jean Delvare wrote:
> Hi Hans,
>
>>
>> # If sensors was not already running, unload the module...
>> [ -e /var/lock/subsys/lm_sensors ] || /sbin/modprobe -r i2c-proc >/dev/null 2>&1
>> fi
>>
>> CONFIG=/etc/sysconfig/lm_sensors
>> -[ -r "$CONFIG" ] || exit 0
>> -grep '^MODULE_' $CONFIG >/dev/null 2>&1 || exit 0
>> +[ -r "$CONFIG" ] || exit 6
>> +grep '^MODULE_' $CONFIG >/dev/null 2>&1 || exit 6
>
> I am worried that this error check (and the one above) is done
> independently of the command, i.e. also for command "status", while the
> document you mentioned above states that the error codes are different
> for this command, and "6" isn't valid there. So I think that the
> configuration file check and loading should be moved to the specific
> commands that need it (start and stop as far as I can see) before you
> can return 6 on missing configuration file.
>
Fixed, new version attached.
>>
>> # Load config file
>> . "$CONFIG"
>> @@ -147,7 +147,7 @@
>> ;;
>> *)
>> echo "Usage: $0 {start|stop|status|restart|reload|condrestart}"
>> - exit 1
>> + exit 3
>
> None of the init scripts in openSuse does this. They all use "exit 1",
> and that sounds reasonable to me. If the user runs "lm_sensors blah",
> it will fail, not because it is an "unimplemented feature" (3) but
> because the user typed a command that doesn't exist. So I wouldn't
> change it, but if you really don't like 1, then 2 ("invalid or excess
> argument(s)") would be a better choice (we have one openSuse script
> that does this.)
>
I've kept the exit 3, this patch was submitted to make the initscripts work
with some gui service configuration tools, these will never pass a non existing
command, but might pass a not supported one, in which case exit 3 is correct. I
don't think any non automated tools will care, and for the automated ones exit
3 is the best return code I believe.
New proposed patch attached.
Thanks & Regards,
Hans
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: lm_sensors-3.0.1-lsb-retcodes.patch
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20080226/4e100775/attachment.pl
