Hi Riku, On Wed, 24 Oct 2007 14:50:34 +0300, Riku Voipio wrote: > On Fri, Oct 19, 2007 at 02:37:54PM +0200, Jean Delvare wrote: > > Take a look at the w83781d > > driver for an example. > > Btw, I think your example code has a indentation bug: > > if (kind != w83781d) > err = sysfs_chmod_file(&dev->kobj, > &sensor_dev_attr_temp3_alarm.dev_attr.attr, > S_IRUGO | S_IWUSR); > if (err) > return err; Indentation is correct, but curly braces are missing! Nice catch, thanks for reporting. It happens to be harmless in this specific case, but it still needs fixing. I'll submit a patch shortly. -- Jean Delvare