> <-- snip -->
>
> ...
> static ssize_t set_pwm_mode(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> ...
> if (val != 0 || val != 1 || data->kind == f75373)
> return -EINVAL;
> ...
>
> <-- snip -->
> I'm not sure what exactly was intended, but it was for sure not intended
> to always return -EINVAL...
Aiee. val should be 1 or 0, and kind must not be f75373.
Signed-off-by: Riku Voipio <riku.voipio at iki.fi>
---
drivers/hwmon/f75375s.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index f1df57a..885bfe9 100644
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -344,7 +344,7 @@ static ssize_t set_pwm_mode(struct device *dev, struct device_attribute *attr,
int val = simple_strtoul(buf, NULL, 10);
u8 conf = 0;
- if (val != 0 || val != 1 || data->kind == f75373)
+ if (!(val == 0 || val == 1 ) || data->kind == f75373)
return -EINVAL;
mutex_lock(&data->update_lock);
--
1.5.3.1
