Hi Jean, On 9/9/07, Jean Delvare <khali at linux-fr.org> wrote: > Hi Juerg, > > On Thu, 6 Sep 2007 20:01:04 -0700, Juerg Haefliger wrote: > > > We must rework the checks in the dme1737 printing functions to process > > > the ignore statements properly, and to only display errors for missing > > > features, not missing channels. I'm attaching the patch I have come up > > > with. I can't test it as I do not have the hardware. Juergen, can you > > > please test and report? > > > > > > Juerg, can you please review and test too? > > > > Ok I'm officially confused now. Your patch only prevents error > > messages if ignore statements are added. Is that the intended > > behavior? > > No, it's not. See how confusing the API is, it managed to fool me. > sensors_get_label() succeeds even for missing features! > > Attached is an updated patch. Voltages and temperatures part is > unchanged (honor ignore statements), fans and pwms part is much more > simple (simply ignore errors). Please test and report. This one behaves correctly. Acked-by: Juerg Haefliger <juergh at gmail.com> ...juerg > Jean Delvare > >
