On Tue, Jul 31, 2007 at 09:06:54AM -0400, Mark M. Hoffman wrote: > My bad. I see you sent a patch for it anyway, so I'll leave it up to you. sparse complains about ARRAY_SIZE() so your method of structuring code is less likely to raise eyebrows. :) > > Could you please just respin a single patch to add the driver with all > cleanups, against v2.6.23-rc1? What you've given me at this point is... > > 1) adt7470 v3 against v2.6.22 > > (you must have done a merge up to v2.6.23-rc1 here) > > 2) cleanups against #1 + v2.6.23-rc1 > > 3) etc. > > I shouldn't have to reproduce that merge here. > > I'm sorry if you feel like I'm being a PITA here... but it's not my primary > goal as a volunteer to optimize the use of your (employer's) time. Merging a patchset isn't a problem; I can take care of that pretty quickly. However, I thought that it would be a good idea to have a public airing of those last three patches individually. Sorry I came off a bit more harshly than I intended in that last email. My apologies. Also, I think git has the ability to import a patchset from a series of emails in mbox format. That said, I know a lot of new drivers tend to show up as a giant block of code and not a patch stream. :) --D -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070731/b851b207/attachment.bin