On Mon, Jul 30, 2007 at 12:11:22AM -0400, Mark M. Hoffman wrote:
> > + /* Register sysfs hooks */
> > + for (i = 0; i < ARRAY_SIZE(adt7470_attr); i++) {
> > + err = device_create_file(&client->dev,
> > + &adt7470_attr[i].dev_attr);
> > + if (err)
> > + goto exit_remove;
> > + }
> > +
>
> Please just use sysfs_create_group() here, as seen in many other hwmon drivers.
I _removed_ the giant static array of struct attribute and the
sysfs_create_group call at Mr. deGoede's suggestion:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-July/020316.html
I'd rather not spend time on busy work re-adding all of that...
(I'll implement the rest of your suggestions and send out another
patch.)
--D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070730/12e30e13/attachment.bin
