[PATCH] v3 of a adt7470 driver\

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 14, 2007 at 07:22:41PM +0200, Hans de Goede wrote:
> Hmm,
> 
> I see it refresh the readings every 2 seconds, since reading things takes 1 
> sec minimum, I think it would be a good idea to make this somewhat bigger. 
> Darrick, can you post a new version and or an incremental patch with a 
> slower read frequency, say once every 5 or 10 seconds?

Will do.  The data sheet says you have to wait 200ms *
number_of_temperature_sensor_chips.  Unfortunately, there's no way to find
out how many sensor chips there are before you read them, but 1s seemed to
work ok for all my systems.  I suppose I could modify the init function
to do the read once with the long delay, then lower it to 200ms *
however many temperature sensors read a "sane" value.

> Also I notice that you are still doing a full read of the chip to 
> data->raw, this might very well explain some if the slowness. Please remove 
> raw[] from data and the full read code from the update() function.

That was pulled from v3.

--D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070716/9d2cf9b1/attachment.bin 


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux