On Thu, Jul 12, 2007 at 11:42:43AM +0200, Hans de Goede wrote:
> Darrick J. Wong wrote:
> >Resend with correct title and patch included just once.
> >---
> >adt7470: new hwmon driver for adt7470 chip.
> >
> >Signed-off-by: Darrick J. Wong <djwong at us.ibm.com>
>
> Looks good now, as far I'm concerned this is ready to get merged.
> Acked-by: Hans de Goede <j.w.r.degoede at hhs.nl>
>
> Mark, any chance you can pick this up soonish, maybe it can make 2.6.23
> then.
>
> Darrick, have you already written support for this driver for libsensors
> and sensors? If not could you please do that ASAP? Then I'll review it and
> with some luck and Jean's permission we can still get support for this chip
> included into lm_sensors 2.10.4
I ... can't say that I have a working config. I've added this into /etc/sensors.conf:
chip "adt7470-*"
label fan1 "CPU0 Fan"
label fan2 "CPU1 Fan"
label temp1 "CPU0 Temp"
label temp3 "CPU1 temp"
label pwm1 "CPU0 Fan Control"
label pwm2 "CPU1 Fan Control"
(There are more pwm/fan/temp widgets but on the Z30 they're not
connected to anything.)
But every time I run sensors (from svn) I see only this:
root at elm3a181:/usr/local/src/lm_sensors/prog# sensors/sensors -c
/tmp/sensors.conf
adt7470-i2c-0-2f
Can't get adapter name for bus 0
I _think_ this has to do with i2c-i801 not exporting something in sysfs
correctly, though I'm not sure. Below is the strace output from sensors
after it finishes probing the hwmon devices.
--D
lstat("/sys/class/i2c-adapter/i2c-0", {st_mode=S_IFLNK|0777, st_size=0, ...}) = 0
lstat("/sys/class/i2c-adapter/i2c-0", {st_mode=S_IFLNK|0777, st_size=0, ...}) = 0
readlink("/sys/class/i2c-adapter/i2c-0", "../../devices/pci0000:00/0000:00:1f.3/i2c-adapter/i2c-0", 256) = 55
readlink("/sys/devices/pci0000:00/0000:00:1f.3/i2c-adapter/i2c-0/subsystem", "../../../../../class/i2c-adapter", 256) = 32
lstat("/sys/class/i2c-adapter", {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
lstat("/sys/devices/pci0000:00/0000:00:1f.3/i2c-adapter/i2c-0/device", {st_mode=S_IFLNK|0777, st_size=0, ...}) = 0
readlink("/sys/devices/pci0000:00/0000:00:1f.3/i2c-adapter/i2c-0/device", "../../../../../devices/pci0000:00/0000:00:1f.3", 256) = 46
lstat("/sys/devices/pci0000:00/0000:00:1f.3", {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
lstat("/sys/devices/pci0000:00/0000:00:1f.3/bus", 0x7fff146427e0) = -1 ENOENT (No such file or directory)
lstat("/sys/devices/pci0000:00/0000:00:1f.3/driver", {st_mode=S_IFLNK|0777, st_size=0, ...}) = 0
readlink("/sys/devices/pci0000:00/0000:00:1f.3/driver", "../../../bus/pci/drivers/i801_smbus", 256) = 35
lstat("/sys/devices/pci0000:00/0000:00:1f.3/subsystem", {st_mode=S_IFLNK|0777, st_size=0, ...}) = 0
readlink("/sys/devices/pci0000:00/0000:00:1f.3/subsystem", "../../../bus/pci", 256) = 16
lstat("/sys/devices/pci0000:00/0000:00:1f.3/name", 0x7fff14642d60) = -1 ENOENT (No such file or directory)
ioctl(3, SNDCTL_TMR_TIMEBASE or TCGETS, 0x7fff14642ea0) = -1 ENOTTY (Inappropriate ioctl for device)
fstat(3, {st_mode=S_IFREG|0644, st_size=458, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2ad196483000
read(3, "chip \"adt7470-*\"\n\tlabel fan1 \"CP"..., 8192) = 458
read(3, "", 4096) = 0
read(3, "", 8192) = 0
ioctl(3, SNDCTL_TMR_TIMEBASE or TCGETS, 0x7fff146417b0) = -1 ENOTTY (Inappropriate ioctl for device)
close(3) = 0
munmap(0x2ad196483000, 4096) = 0
open("/usr/lib/gconv/gconv-modules.cache", O_RDONLY) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=25460, ...}) = 0
mmap(NULL, 25460, PROT_READ, MAP_SHARED, 3, 0) = 0x2ad196483000
close(3) = 0
open("/usr/lib/gconv/ISO8859-1.so", O_RDONLY) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\300\4\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=10200, ...}) = 0
mmap(NULL, 2105392, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x2ad1970a7000
mprotect(0x2ad1970a9000, 2093056, PROT_NONE) = 0
mmap(0x2ad1972a8000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1000) = 0x2ad1972a8000
close(3) = 0
fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 2), ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2ad1972aa000
write(1, "adt7470-i2c-0-2f\n", 17adt7470-i2c-0-2f
) = 17
write(2, "Can\'t get adapter name for bus 0"..., 33Can't get adapter name for bus 0
) = 33
write(1, "\n", 1
) = 1
exit_group(0) = ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070712/ca0ff55a/attachment.bin
