[PATCH] hwmon: Fix a potential race condition on unload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi:

* Jean Delvare <khali at linux-fr.org> [2007-06-12 13:57:19 +0200]:
> Fix a potential race condition when some hardware monitoring platform
> drivers are being unloaded. I believe that the driver data pointer
> shouldn't be cleared before all the sysfs files are removed, otherwise
> a sysfs callback might attempt to dereference a NULL pointer. I'm not
> sure exactly what the driver core protects drivers against, so let's
> play it safe.
> 
> While we're here, clear the driver data pointer when probe fails, so
> as to not leave an invalid pointer behind us.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>

Applied to testing w/ one addition for vt8231...

--- a/drivers/hwmon/vt8231.c
+++ b/drivers/hwmon/vt8231.c
@@ -743,6 +743,7 @@ exit_remove_files:
        sysfs_remove_group(&pdev->dev.kobj, &vt8231_group);
 
 exit_free:
+       platform_set_drvdata(pdev, NULL);
        kfree(data);
 
 exit_release:

Thanks & regards,

-- 
Mark M. Hoffman
mhoffman at lightlink.com





[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux