Hi Jean, > There are no standard registers and no standard values to identify I2C > manufacturers and devices. So adding a few tests where possible cannot > hurt and is considered a good practice. So unless you have a reason to > believe that these tests could fail for an otherwise valid chip, I'd > leave them in. Especially the test of register 0x40 is valuable - the > test of register 0x42 certainly less. > > We don't need to do this for Super-I/O or PCI devices because they have > standard identification registers. > > Can you please provide a patch fixing sensors-detect for the DME1737? Do you mean just fixing the 0x55? ...juerg > Thanks, > -- > Jean Delvare >
