Hi Yuan, > > > I add the lock to all store functions in this patch, please can > > > you check? > > > > It's OK except in store_pwmenable where you would leave with the lock > > held on incorrect input value. > > > > Your patch also lacked your signed-off-by line, and a proper summary... > > Sorry, maybe i heat my head too heavily last time :( > Can you check this one, thanks :) No problem. I applied it with just one fix: > default: > - return -EINVAL; > + break; > } This made the default case pretty useless so I dropped it altogether. Thanks, -- Jean Delvare