Hi Yuan, > I add the lock to all store functions in this patch, please can > you check? It's OK except in store_pwmenable where you would leave with the lock held on incorrect input value. Your patch also lacked your signed-off-by line, and a proper summary... -- Jean Delvare