>>> I'm proposing that some of funcs can be done via macro or 2D array. >>> This might help to shrink the source code a bit. >> >> I had it this way in the begining but threw it out for some reasons I >> can't remember anymore. I'll take a look at it again. > > Maybe Jean have some idea about it too? Or others? I fixed it already, don't bother. >>> I'm not user about the runtime UCONFIG configuration. Perhaps cleanest >>> solution would be to create/remove sysfs nodes runtime instead of >>> exporting them with zero. >> >> I don't understand. Exporting the UCH config register is a left-over >> from the 2.4 driver. I think the reason why it's in the 2.4 driver is >> because some BIOSes don't set it correctly. Maybe this is not true >> anymore and we can now fully rely on the BIOS doing it right and don't >> need to export the register anymore. Comments anyone? > > Well me. I think we can drop this interface and read the UHC > conf only at the driver start. User with bad BIOS config can > do i2cset/isaset commands if neccessary to change the config > and then load the driver. > hmm... libsensor currently supports this interface. Is it deprecated? Using i2c to change it would be OK I guess, except that the driver itself doesn't need i2c anymore (it's platform) and the user would have to compile i2c just for this (if required, that is). How about using a module load parameter instead? ...juerg
