Hi Dean, Please start a new thread when starting a new topic. On 2006-02-06, Dean Takemori wrote: > Submitted for the upcoming 2.10.0 release: To upgrade the > fancontrol.init script to the version I've been using for a while now > on an FC1 system. Please list the changes between the old and the new version. Are these bug fixes? New features? The diff is very large (compared to the size of the script) and it looks much like a complete rewrite to me, while we want incremental changes. Also there is a lot of noise due to reindentation. This makes the review very difficult. Please separate the coding style cleanups from the functional changes. If there are any bug fixes in there, please extract them and send a minimal patch for 2.10.0. We are not going to merge a complete rewrite right before a release. Thanks, -- Jean Delvare
