Hi Mark, On 2005-11-20, Mark M. Hoffman wrote: > * Jean Delvare [2005-11-15 12:16:52 +0200]: > > While checking the W83627THF datasheet, I noticed that there is an > > additional GPIO configuration register, CRF5, named "inversion > > register". Wouldn't it make sense to check the value of this register > > and make sure all pins supposedly used as VID inputs are not inverted? > > Mark, can you please confirm that your system which does use GPIO5 for > > VID would pass that test? Proposed patch attached, comments and testers > > welcome. > > Your patch does work on my system, but... no, I don't think it means > anything if the inputs are inverted or not. The BIOS might set the inputs > to inverted if the VID signals are inverted by hardware... which I would > not consider to be unusual or unexpected. I do consider it to be unexpected. The W83627HF cannot invert these pins as far as I know, so if the W83627THF is supposed to be used as a replacement for the W83627HF, the GPIO pins shouldn't be inverted. Additionally, the VID signals are supposed to come directly from the CPU, and if they do they cannot be inverted. > Of course, it might just as well leave them *not* inverted *despite* that > they are inverted in hardware... which suggests a new module option if > anyone ever discovers such a board. That would be a different problem (getting the proper value, as opposed to properly guessing if the pins are used as VID inputs), although the same reasons I gave above make me doubt this could actually happen. > BTW: I tested by applying your current quilt stack (up to and including > the improve-gpio5-test patch) to 2.6.15-rc2. Great, thanks. I'll probably push upwards a part of it this week so that it gets a broader testing in -mm. -- Jean Delvare
