Hi Jean: * Jean Delvare <khali at linux-fr.org> [2005-11-15 12:16:52 +0200]: > While checking the W83627THF datasheet, I noticed that there is an > additional GPIO configuration register, CRF5, named "inversion > register". Wouldn't it make sense to check the value of this register > and make sure all pins supposedly used as VID inputs are not inverted? > Mark, can you please confirm that your system which does use GPIO5 for > VID would pass that test? Proposed patch attached, comments and testers > welcome. Your patch does work on my system, but... no, I don't think it means anything if the inputs are inverted or not. The BIOS might set the inputs to inverted if the VID signals are inverted by hardware... which I would not consider to be unusual or unexpected. Of course, it might just as well leave them *not* inverted *despite* that they are inverted in hardware... which suggests a new module option if anyone ever discovers such a board. BTW: I tested by applying your current quilt stack (up to and including the improve-gpio5-test patch) to 2.6.15-rc2. Regards, -- Mark M. Hoffman mhoffman at lightlink.com
