Hi Grant, > > Great, except for: > > > > > - } > > > - > > > + > > > > Please avoid this "noise" change (same holds for all future patches, of > > course). > > Fine, I'll wait until your CodingStyle patches go through, as twice now > I've been told by you to violate CodingStyle. Understanding yet to dawn > as to why this is so. Can you please point me to the exact rule you think I told you to violate? I don't think I really did. What you were doing here is fix coding style while the main point of your patch was to remove a deprecated feature. As per Documentation/SubmittingPatches section 3, these changes should be sent as two different patches. Doing so eases the work of all reviewers and maintainers up the chain, and is all I was asking for. Thanks, -- Jean Delvare