On Sun, Jun 05, 2005 at 10:51:46AM +0200, Jean Delvare wrote: > Hi Yani, all, > > > Finally (phew!) this patch demonstrates how to adapt the adm1026 to > > take advantage of the new callbacks, and the i2c-sysfs.h defined > > structure/macros. Most of the other sensor/hwmon drivers could be > > updated in the same way. The odd few exceptions (bmcsensors for > > example) however might be better off with their own custom attribute > > structure. > > I just noticed that this patch has a repeated coding style error: > > + struct sensor_device_attribute *sensor_attr= to_sensor_dev_attr(attr); > > should be: > > + struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr); > > Can we apply this modified version instead? Or is an incremental patch > preferred? I've replaced the version in my tree with this one, thanks. greg k-h