Hi Greg, On Wed, 2005-06-01 at 21:51 -0700, Greg KH wrote: > On Thu, Jun 02, 2005 at 12:06:55AM -0400, Mark M. Hoffman wrote: > > * Greg KH <greg at kroah.com> [2005-05-31 16:32:15 -0700]: > > > This code is _very_ close to just a copy of the i2c core code. Why > > > duplicate it and not work with the i2c people instead? > > > > It was discussed briefly on the lm-sensors mailing list [1]. I didn't > > reply at the time, but I do agree that SPI and I2C/SMBus are different > > enough to warrant independent subsystems. > > Independant is fine. But direct copies, including making the same > mistakes (i2c dev interface, i2c driver model mess) isn't :) I have also worked on a(nother) SPI layer implementation. Like Dmitry, I ended up following closely the i2c implementation, so, I'm curious to know more details on what you call "i2c driver model mess". > thanks, > > greg k-h Thanks, Rui
