Re: [RFC PATCH 2.6.12-rc3-mm2 1/2] i2c: new sysfs class "hwmon"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yani,

> (...) It would seem to me that basically everything
> under drivers/i2c/chips should be moved into drivers/hwmon

No, not all i2c chip drivers are hardware monitoring monitors. At least
the following should stay in drivers/i2c/chips:
* ds1337
* eeprom
* isp1301_omap (what is this BTW?)
* m41t00
* pcf8574
* pcf8591
* rtc8564

And then there's atxp1, not too sure what to do with this one (it's
meant to overclock systems, not monitor them, but it shares code and
interface with hwmon).

> (...) and perhaps
> drivers/i2c/bus to drivers/i2c (although the latter isn't necessary,
> it just makes sense to me).

I don't this it is a good idea. The current scheme makes it clear which
drivers create i2c busses, which are i2c chip drivers, which are
algorithms and which are core drivers. I wouldn't change that.

Thanks,
--
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux