[PATCH 2.6] I2C: Kill another macro abuse in via686a

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Grant,

> Can I go kill some macros too?  Silly conversion macros, make like
> adm9240? Was planning to put SCALING() in with SENSORS_LIMIT() in
> the header somewhere, as those two static functions can be used for
> most of the scaling conversions.

Macros that do not actually improve the code readability are candidates
to removal, as they additionally slow down the preprocessing. Removing
macros is not a goal per se though, most of them are actually helpful.

> As well, do something with the LM75 include, I see now I duplicated
> some of the code there, with exception that I right justify signed
> 9-bit temp on read to local store, rather than on delivery to sysfs.

If you can refactor some code with no side effect, this is welcome.

--
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors at lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux