RFC PATCH libsensors: change vid for adm1025, adm1026 and adm9240

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Grant,

> Thankyou, but I noticed RW and changed it to R in adm1026

True, nice catch.

> > This one is not needed, as it will be properly handled by a "constant
> > mapping" in proc.c.
>
> Is that the same for adm9240?  I tried to follow same style.

Yes it is, I hadn't noticed.

>     { SENSORS_ADM9240_VID, "vid", NOMAP, NOMAP,
>-                  R, ADM9240_SYSCTL_VID, VALUE(1), 2, "in1_ref", 3 },
>+                  R, ADM9240_SYSCTL_VID, VALUE(1), 3 },

You're changing the magnitude for the 2.4 driver here! This is no good.

Thanks,
--
Jean Delvare



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux