On Tue, May 10, 2005 at 10:55:49AM -0700, Greg KH wrote: > > --- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-05-10 14:10:49.637992600 +0200 > > +++ linux-omap/drivers/i2c/chips/ds1337.c 2005-05-10 14:13:05.064404656 +0200 > > @@ -380,5 +380,7 @@ > > MODULE_DESCRIPTION("DS1337 RTC driver"); > > MODULE_LICENSE("GPL"); > > > > +EXPORT_SYMBOL(ds1337_do_command); > > EXPORT_SYMBOL_GPL() ok? I do not realy care (and I think since unfamous SCO case people care more about licenses than writing code). James is driver author, so I'll do whatever he (and you) think is right. And while you bring up license issue, comment on top of file says GPL version 2, but MODULE_LICENSE is set to GPL. Best regards, ladis