On Sun, May 08, 2005 at 10:23:51PM +0200, Jean Delvare wrote: > Hi James, > > > I suggest that Ladislav's patch should still be applied and a > > separate patch be submitted to export the interface to modules. > > Either way is fine with me as long as it actually happens. Export ds1337_do_command so it could be used also if driver is built as module. Signed-off-by: Ladislav Michl <ladis at linux-mips.org> --- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-05-10 14:10:49.637992600 +0200 +++ linux-omap/drivers/i2c/chips/ds1337.c 2005-05-10 14:13:05.064404656 +0200 @@ -380,5 +380,7 @@ MODULE_DESCRIPTION("DS1337 RTC driver"); MODULE_LICENSE("GPL"); +EXPORT_SYMBOL(ds1337_do_command); + module_init(ds1337_init); module_exit(ds1337_exit);