Hi Dmitry, Even for static attributes the void * can be very useful, there are many cases, maybe even most cases (I'm looking through all the sysfs attribute code looking to update it to take advantage of this patch now) where static attributes using the void * are fine and the attribute is not shared amongst different clients/instances of code. For example, adm1026 we could use the index for that static attributes as my previous patch shows and we really need a macro in that case. Or look at net/core/net-sysfs.c, the macros NETDEVICE_SHOW, NETDEVICE_ATTR, etc are best replaced by static attributes using a single callback function and using the void *, for which we really need a macro to set the void *. Perhaps declaring seperate macros for this (e.g. DEVICE_ATTRIBUTE_DATA, such as I defined in the adm1026 example patch) would be more clear? Thanks, Yani On 5/6/05, Dmitry Torokhov <dtor_core at ameritech.net> wrote: > Hi Yani, > > On Friday 06 May 2005 01:40, Yani Ioannou wrote: > > We would probably want to define another DEVICE_ATTRIBUTE like macro > > or add a void * parameter to the DEVICE_ATTRIBUTE macro. Any opinions > > on which way to go? This might be done for the other *_ATTRIBUTE > > macros too. > > > > No, I don't think so. Again, macros are normally used to initialize > statically allocated attributes, exposing void * pointer does not do > them any good. It can only lead to bugs when driver writer misses the > fact that pointer is shared between all instances of attribute. > > -- > Dmitry >
