On Wednesday 27 April 2005 12:16, Greg KH wrote: > As a side note, wouldn't it make sense to check, when creating sysfs > files, that readable files have a non-NULL show method, and writable > files have a non-NULL store method? I know drivers are not supposed to > do stupid things, but there is already a BUG_ON for several conditions > in sysfs_create_file, so maybe we could add two more? Checking at creation time is not enough. Even with such check one could change permissions on a sysfs file and set write bit. -- Dmitry
