On Mon, Mar 28, 2005 at 09:16:32PM +0200, Jean Delvare wrote: > Hi Greg, > > While investigating the i2c chips drivers that were not properly > locking, we found that the pcf8574 driver does the exact contrary. It > uses a lock where it's not needed. > > While we were there, we did some additional cleanups to the driver: > 1* Merge pcf8574_update_client() in show_read(), as it was the only user > and the function became trivial once the locking was removed. > 2* Add a validity check on values provided by user-space. > > Aurelien Jarno tested the modified code for confirmation and it worked > just fine. > > Please apply, Applied, thanks. greg k-h