Hi Greg, I noticed a race condition in the it87, affecting the IT8712F chip only. The VRM value is currently initialized *after* creating the vrm and vid sysfs files. This leaves a theorical room for reading from these files and get an invalid value. It's not critical, but let's still fix it. Please apply, thanks. Signed-off-by: Jean Delvare <khali at linux-fr.org> --- linux-2.6.12-rc1-mm1/drivers/i2c/chips/it87.c.orig Thu Mar 24 14:06:35 2005 +++ linux-2.6.12-rc1-mm1/drivers/i2c/chips/it87.c Thu Mar 24 14:08:24 2005 @@ -889,9 +889,9 @@ } if (data->type == it8712) { + data->vrm = i2c_which_vrm(); device_create_file_vrm(new_client); device_create_file_vid(new_client); - data->vrm = i2c_which_vrm(); } return 0; -- Jean Delvare