Hi MDS Thank you for your suggestion. The following is my reply. > 1) alarms > The module does not export an 'alarms' entry in /proc, and to generate the > ALARM indication in sensors/chips.c > it simply does a comparison to min/max values. This is undesirable and not > according to our standard. > Reading and exporting the bits in the alarms registers (0x41,0x42,0x9b) > is much preferred because the chip > latches the alarms between reads. See the other winbond drivers and > corresponding support in sensors/chips.c for examples. Yes, I can catch your meaning :-) The method I use is of "software-level", while the other drivers in lm_sensors use the "hardware-level" method. I finish it with the reference to our Windows driver, it does NOT use the registers CR[0x41], CR[0x42], CR[0x9b] either, and can work well. Do you suggest that I change my method into yours? If do, I will modify it when I'm a little free, because besides porting 792 driver into linux-2.6, I'm busy attending another job about smart card. And you may also modify it for me if you have time. :-) > 2) subclient registration > The module should register the 'subclients' (the two emulated lm75 chips) > so that other drivers do not claim them. > You can copy this code from w83781d.c I noticed the subclient registration when I started to write 792 driver, I'm not familiar with subclient and sent lm_sensors group a mail for your introduction about it about several month ago, but do not receive any response. Since I'm not familiar with it, I discard it just like the other chip drivers: lm90.c and lm83.c, finding it can work well. > 3) fan speeds in /proc > Sometimes the fan speeds in /proc are large negative numbers: > w83792d-i2c-1-2d/fan1 > 187 -556712672 > w83792d-i2c-1-2d/fan2 > 100 0 > w83792d-i2c-1-2d/fan3 > 1695 3835 > w83792d-i2c-1-2d/fan4 > 6000 0 > w83792d-i2c-1-2d/fan5 > 12857 0 > w83792d-i2c-1-2d/fan6 > 6783 0 > w83792d-i2c-1-2d/fan7 > -1 -556712672 > I think it's because you don't always set a value to results[1] in > w83792d_fan(). There are several > if-then-else cases where no value is set. Hm...I think this phenomenon appear when the fan divisor modifying itself in the "do...while (0)" loop in w83792d_fan(), Once the fan divisor reaches a reasonable after some time, it will disappear. Maybe there is some bug in this function, I will debug it in the near future. > 4) a documentation file for doc/chips would be greatly appreciated :) Yes, you are right, I will send you the document when I finish it in the future. Thanks Best Regards Chunhao ===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repea! t the English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??.
