On Wed, 2 Feb 2005 11:14:18 -0800 Nishanth Aravamudan <nacc at us.ibm.com> wrote: > Hello, Hello. > Please consider applying. > > Description: Replace deprecated interruptible_sleep_on_timeout() with direct > wait-queue usage. Ideally, I would use wait_event_interruptible_timeout(); > however, there is no condition to sleep on here, unless I was to use the > try_to_freeze() call as one. That is not the case in the current code, though, > and I'm not sure it can/should be. Since timeout is a jiffies-unit variable, > change the type to unsigned long. Patch is compile-tested. Second part of the patch(changing w1_process() sleeping path) is not 100% right. Although all those sleeps are just waitings for given timeout to check various flags - since awakening only happens on signal, we can just replace them with msleep_interruptible() and appropriate try_to_freeze(). I will prepare a patch tomorrow, thank you. > Signed-off-by: Nishanth Aravamudan <nacc at us.ibm.com> Evgeniy Polyakov Only failure makes us experts. -- Theo de Raadt
