On Wed, Dec 08, 2004 at 09:07:43PM +0100, Jean Delvare wrote: > > /* default: SMBus, no SMI#, enable host controller */ > > pci_write_config_byte(pcidev, I801_PCI_HOSTC, 0x01); > > pci_read_config_byte(pcidev, I801_PCI_HOSTC, &temp); > > And after that you don't use temp... Am I missing something? This is commonly done to ensure that the write actually hits the bus before the code continues. Otherwise, the write could happen at some later point in time. The read after a write ensures that everything is synced up properly. > You might want to only write the bits that you know about, in case > future chips would have more. Also you could use the constants you > defined earlier. What about: > > > /* default: SMBus, no SMI#, enable host controller */ > > pci_read_config_byte(pcidev, I801_PCI_HOSTC, &temp); > > pci_write_config_byte(pcidev, I801_PCI_HOSTC, > > (temp & 0xF8) | I801_PCI_HOSTC_HST_EN); And then put a read after it too :) thanks, greg k-h
