On Wed, Nov 24, 2004 at 03:10:17PM -0800, Justin Thiessen wrote: > On Wed, Nov 24, 2004 at 01:36:00PM -0800, Greg KH wrote: > > Hm, this looks like a bug: > > <snip egregious stupidity> > > > Care to fix this up and resend the whole patch? > > Affirmative. > > > Oh, and it should be "Signed-off-by:" not "Signed off by:" like you had > > used :) > > See below: Applied, thanks. Oh, I did make one change: > +/* Adjust fan_min to account for new fan divisor */ > +void fixup_fan_min(struct device *dev, int fan, int old_div) This should be static. thanks, greg k-h