> Taking into account Arjan's comments, I have fixed the awkward > locking constructs. I have also switched from using MODULE_PARM() > to module_param_array(). As Jean requested (and as I muttonheadedly > ignored) on the last submission, the diff now includes the patches to > > .../drivers/i2c/chips/Makefile > .../drivers/i2c/chips/Kconfig Great, looks good enough to me. I'd like to see this patch applied to the kernel. Any further change can be done through incremental patches, which are so easier to review. Thanks Justin for the good work :) -- Jean Delvare http://khali.linux-fr.org/