[CCing Mario who originally submitted the bug report]
Jean Delvare wrote:
>>Currently sensord is logging load1 when used with the --load-average
>>option. It does not make much sense to do that for a 5 minutes RRD
>>update interval (the default one).
>
>
> I think it does. The fact that the update interval is 5 minutes is
> hardly relevant. The point is that sensord reports instant measurements
> for everything (voltages, temperatures, etc...) and the 1 minute average
> load is the nearest value from instant load.
I agree with that, however, the others measurements (and particularly
temperatures) are changing slowly so that interpolation done bye RRD can
work. This is not the case of the load.
>>The best solution is to let the user to choose which load he wanted
>>to log according to the update interval and other things.
>>
>>That's the purpose of the attached patch. Using it, it possible to
>>select the load average to log. For example --load-average 1,5,15
>>logs load1, load5 and load15.
>
>
> I don't think this belongs to sensord. Sensord is not a system
> monitoring daemon but a hardware monitoring daemon. The only reason why
> load "average" is included is that several monitored values (CPU temp
> first) may depend on the instant system load. Logging load5 or load15
> doesn't make much sense IMHO.
Ok, here is an example. Imagine that your system has a high load during
the first four minutes of a five minutes interval, and a low load the
during last minute. In that case the CPU temperature would still be
high, but the load would be low if load1 is logged. So logging load1 in
that case wouldn't make much sense. In that case logging load5 is a
better idea IMHO.
> The only think I would agree isn't really right is the name of the
> option. --load-average should be --load instead (or maybe
> --instant-load, although it could be even more misleading since that's
> not exactly what load1 is). I don't think it's worth breaking the
> interface though.
BTW, the patch doesn't break the interface as the argument is optional.
--load-average without arguments goes back to the previous behavior.
--
.''`. Aurelien Jarno GPG: 1024D/F1BCDB73
: :' : Debian GNU/Linux developer | Electrical Engineer
`. `' aurel32 at debian.org | aurelien at aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
