Hi Alex: * Alexandre d'Alton <alex at alexdalton.org> [2004-09-20 08:21:53 +0200]: > If I remember, it is not because depending on the mode (auto or manual > PWM), the same register has a different behaviour. Jean asked to make > two sysfs files in order to keep the interface consistant (and > chip-independant...) Aha, OK. Sorry for the noise. > On Mon, 2004-09-20 at 07:00, Mark M. Hoffman wrote: > > > > > Two other things... > > > > (One) In adm1031.c lines 594-595: > > > > > static DEVICE_ATTR(auto_fan##offset##_min_pwm, S_IRUGO | S_IWUSR, \ > > > show_pwm_##offset, set_pwm_##offset) > > > > But those are also used for the sysfs files fan?_pwm in lines 439-440: > > > > > static DEVICE_ATTR(fan##offset##_pwm, S_IRUGO | S_IWUSR, \ > > > show_pwm_##offset, set_pwm_##offset) > > > > That's a bug, right? Regards, -- Mark M. Hoffman mhoffman at lightlink.com
