w83781d and alarms for temp2 and temp3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Please find attached two patches to fix that, one concerning sensors
> and the other one concerning sensord.
> 
> The patch for sensors is almost the same as the previous one, but now
> the code would compile!
> 
> The patch for sensord looks like a little bit long. That's because the
> code was shared between w83781d and as99127f chips. With this patch,
> the two chips are handled separatly

About the sensors patch: fix is correct, but indentation isn't. I'll
take care of that though, no need to resend.

About the sensord patch: I don't like it. You do not need to define
separate constants for the AS99127F in lib/chips.h. We can do without
them. Just use the SENSORS_W83781D defines in the as99127f_features
array (much like w83697hf_features uses the SENSORS_W83782D defines).

Care to provide a new patch?

Thanks.

-- 
Jean Delvare
http://khali.linux-fr.org/



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux