On Fri, Jan 16, 2004 at 07:52:55PM +0100, Jean Delvare wrote:
> > Depends on what the patch looks like. Care to make it up to see if
> > it's not too ugly?
>
> Here you go. Comments at the bottom.
Ok, very persuasive argument, I've applied this :)
One comment:
> - if ((jiffies - data->last_updated > 300 * HZ) |
> - (jiffies < data->last_updated) || !data->valid) {
> - dev_dbg(&client->dev, "Starting eeprom update\n");
> + if (!(data->valid & (1 << slice)) ||
> + (jiffies - data->last_updated[slice] > 300 * HZ) ||
> + (jiffies < data->last_updated[slice])) {
We do these jiffies comparisons a lot, is everyone sure they are
correct? We should probably be using the proper macros/functions for
this, right? I think I looked at this a while ago, and think they look
correct, but it would be good if someone else can verify this.
thanks,
greg k-h
