Make the on-chip temp sensor be temp1. On the ram array, it's a strange winbond convention that calls some of the registers a ram array but not others. It doesn't really matter to us. You can implement the driver local storage (variables in struct w83784_data) any way you want. If you can have more efficient code by putting it a big 'ram' array then why not? Rudolf Marek wrote: > > > what standards we have are in doc/developers/proc. > > the two examples you cited, we don't have standards for. > > Ok thank you. > > Good news. Driver works, but I have there for sensors data ram one array > called 'ram'. > > Rest of values obtained from various registers are stored > in variables pwm_duty[] etc. > > I guess I should remove the monolithic 'ram' array and split it into > logicaly smaller pieces. Right ? > > Also I would like ask about the register adress mappings. > > For example on lower reg number is stored temp2 and on next temp1. > I solved this by ordering the sysctl numbers. T2 got lower. > > Is it OK or should I make some #define with mapping macro ? > > Regards > > Rudolf > >