On Wed, 2003-03-26 at 22:29, Greg KH wrote: > Some of the nasty casts should be fixed up though. Stuff like: > > > + ERROR7: > > + if (!is_isa) > > + i2c_detach_client(& > > + (((struct w83781d_data > > + *) (i2c_get_clientdata(new_client)))-> > > + lm75[1])); > > + ERROR6: > > + if (!is_isa) > > + i2c_detach_client(& > > + (((struct w83781d_data > > + *) (i2c_get_clientdata(new_client)))-> > > + lm75[0])); > > + ERROR5: > > + if (!is_isa) > > + kfree(((struct w83781d_data *) (i2c_get_clientdata(new_client)))-> > > + lm75); > > Is just obnoxious :) > Quick question .... With sysfs, is it not needed to call i2c_detach_client ? I am asking this as it seems from patches that you remove all these calls ... Regards, -- Martin Schlemmer -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20030327/e8b15229/attachment.bin
