On Wed, Mar 26, 2003 at 09:04:33PM +0200, Martin Schlemmer wrote: > Hi > > Ok, this is the w83781d driver updated for 2.5.66bk2. It works > over here. Looks nice, thanks. Some of the nasty casts should be fixed up though. Stuff like: > + ERROR7: > + if (!is_isa) > + i2c_detach_client(& > + (((struct w83781d_data > + *) (i2c_get_clientdata(new_client)))-> > + lm75[1])); > + ERROR6: > + if (!is_isa) > + i2c_detach_client(& > + (((struct w83781d_data > + *) (i2c_get_clientdata(new_client)))-> > + lm75[0])); > + ERROR5: > + if (!is_isa) > + kfree(((struct w83781d_data *) (i2c_get_clientdata(new_client)))-> > + lm75); Is just obnoxious :) I'll hold off sending this driver to Linus until it gets cleaned up with sysfs entries, as I'd rather not pollute /proc and sysctls anymore. thanks, greg k-h
