On Tue, Mar 25, 2003 at 02:04:19AM +0000, Dave Jones wrote: > On Mon, Mar 24, 2003 at 05:29:23PM -0800, Greg KH wrote: > > > > > + .name = "ADM1021-MAX1617", > > > Why dash here > > > > + .name = "LM75 sensor", > > > And space here? Also you should have > > > either 2x "sensor" or none at all. > > What do you mwan "2x"? > > The way I parsed it, either have.. > .name = "ADM1021-MAX1617 sensor", > .name = "LM75 sensor", > > or > > .name = "ADM1021-MAX1617", > .name = "LM75", > > ie, both, or all. Personally the latter looks better to me. Ah, yes, that makes more sense now. Yes, we shouldn't have the "sensor" in the name. > Especially given the 16 char limit. Aren't these going to > be in a sysfs heirarchy where its obvious they are sensors > anyway ? like i2c/sensors/lm75 ? Yes, they show up as bus/i2c/drivers/ thanks, greg k-h
