[PATCH] More i2c driver changes for 2.5.65

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 24, 2003 at 05:29:23PM -0800, Greg KH wrote:

 > > > +	.name		= "ADM1021-MAX1617",
 > > Why dash here
 > > > +	.name		= "LM75 sensor",
 > > And space here? Also you should have 
 > > either 2x "sensor" or none at all. 
 > What do you mwan "2x"?

The way I parsed it, either have..
 .name = "ADM1021-MAX1617 sensor",
 .name = "LM75 sensor",

or

 .name = "ADM1021-MAX1617",
 .name = "LM75",

ie, both, or all. Personally the latter looks better to me.
Especially given the 16 char limit.  Aren't these going to
be in a sysfs heirarchy where its obvious they are sensors
anyway ? like i2c/sensors/lm75 ?

		Dave



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux