fyi -------- Original Message -------- Subject: Re: [PATCH]2.4.20 ARCH=i386 create dmi_scan.h and move decl fromdmi_scan.c Date: 13 Aug 2002 13:13:04 +0100 From: Alan Cox <alan at lxorguk.ukuu.org.uk> To: Albert Cranford <ac9410 at attbi.com>,Linus Torvalds<torvalds at transmeta.com> CC: Marcelo Tosatti <marcelo at conectiva.com.br>,Linux Kernel List<linux-kernel at vger.kernel.org> References: <3D589E11.6093B119 at attbi.com> On Tue, 2002-08-13 at 06:50, Albert Cranford wrote: > - > -static char *dmi_ident[DMI_STRING_MAX]; > +char *dmi_ident[DMI_STRING_MAX]; Be very careful with this change btw. The dmi_ident strings are unmapped at the point dmi_table() returns. That means you can only use them in the decode callback, and so it seems odd to export them. It certainly wants clear documentation if you are doing it that way. What you probably should do is create some flag bits for i2c/smbus and set those then export the flag data (we do the same for APM), rather than export them as globals
