On Wed, 2 Oct 2019, Petr Mladek wrote:
> On Thu 2019-09-05 14:45:14, Miroslav Benes wrote:
> > Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>
>
> This might depend on personal preferences.
True.
> What was the motivation
> for this patch, please? Did it just follow some common
> style in this source file?
We had it like this once, so it is only going back to the original code.
And yes, I think it is better.
Commit b56b36ee6751 ("livepatch: Cleanup module page permission changes")
changed it due to the error handling. Commit 255e732c61db ("livepatch: use
arch_klp_init_object_loaded() to finish arch-specific tasks") removed the
reason for the change but did not cleanup the rest.
> To make it clear. I have no real preference. I just want to avoid
> some back and forth changes of the code depending on who touches
> it at the moment.
I have no real preference either. I noticed something I did not like while
touching the code and that's it.
> I would prefer to either remove this patch or explain the motivation
> in the commit message. Beside that
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
Ok, thanks.
Miroslav
