WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. The information is passed also via the return value. The only current user klp_check_stack() writes its own warning when the reliable stack traces are not supported. Other eventual users might want its own error handling as well. Signed-off-by: Petr Mladek <pmladek@xxxxxxxx> Acked-by: Miroslav Benes <mbenes@xxxxxxx> Reviewed-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> --- kernel/stacktrace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c index 5667f1da3ede..8d088408928d 100644 --- a/kernel/stacktrace.c +++ b/kernel/stacktrace.c @@ -259,7 +259,6 @@ __weak int save_stack_trace_tsk_reliable(struct task_struct *tsk, struct stack_trace *trace) { - WARN_ONCE(1, KERN_INFO "save_stack_tsk_reliable() not implemented yet.\n"); return -ENOSYS; } -- 2.16.4